opentelemetry-go fix callback err not return

fix callback err not return

Open NameHaibinZhang opened this issue 6 months ago • 3 comments

for _, c := range p.callbacks {
	// TODO make the callbacks parallel. ( #3034 )
	if e := c(ctx); e != nil {
		err = errors.Join(err, e)
	}
	if err := ctx.Err(); err != nil {
		rm.Resource = nil
		clear(rm.ScopeMetrics) // Erase elements to let GC collect objects.
		rm.ScopeMetrics = rm.ScopeMetrics[:0]
		return err
	}
}
for e := p.multiCallbacks.Front(); e != nil; e = e.Next() {
	// TODO make the callbacks parallel. ( #3034 )
	f := e.Value.(multiCallback)
	if e := f(ctx); e != nil {
		err = errors.Join(err, e)
	}
	if err := ctx.Err(); err != nil {
		// This means the context expired before we finished running callbacks.
		rm.Resource = nil
		clear(rm.ScopeMetrics) // Erase elements to let GC collect objects.
		rm.ScopeMetrics = rm.ScopeMetrics[:0]
		return err
	}
}

if ctx.Err() is not nil, the c(ctx) err is not return