opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Re-add previous metric bridge

Open dashpole opened this issue 3 years ago • 4 comments

I realized its ~trivial to support the previous method of invoking the OC metric bridge, so it might be best to include this, rather than break users until the new design is ready. See https://github.com/open-telemetry/opentelemetry-go/pull/3184#issuecomment-1251199036

Opening this as an option.

dashpole avatar Sep 19 '22 17:09 dashpole

Codecov Report

Merging #3192 (84fbef7) into main (b6d4335) will decrease coverage by 0.1%. The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3192     +/-   ##
=======================================
- Coverage   77.4%   77.3%   -0.2%     
=======================================
  Files        158     159      +1     
  Lines      11084   11101     +17     
=======================================
  Hits        8583    8583             
- Misses      2306    2323     +17     
  Partials     195     195             
Impacted Files Coverage Δ
bridge/opencensus/internal/ocmetric/metric.go 93.8% <ø> (ø)
bridge/opencensus/metric.go 0.0% <0.0%> (ø)

codecov[bot] avatar Sep 19 '22 18:09 codecov[bot]

Depends on fix in https://github.com/open-telemetry/opentelemetry-go/pull/3193

MrAlias avatar Sep 19 '22 20:09 MrAlias

I had to move the opencensusmetric/internal package because it wasn't accessible from where I wanted to place the bridge...

dashpole avatar Sep 19 '22 21:09 dashpole

rebased on the test fix

dashpole avatar Sep 19 '22 21:09 dashpole