opentelemetry-go
opentelemetry-go copied to clipboard
fix SpanKind type assertion in opentracing bridge
We have system which supports multiple distributed tracing systems. When using opentracing bridge, all the spankinds are created as INTERNAL due to type assertion issue in bridge module.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: Prajithp / name: Prajith (bf1d89d283b891a6e1af0ab7bbc04a9bec765323, 48833d75fa6b72dfbc97c767d8b489762e229880)
Can you fix the tests?
@dmathieu Done. I have already signed the CLA document.
Codecov Report
Merging #2898 (784aed8) into main (d96e8d2) will decrease coverage by
0.0%. The diff coverage is100.0%.
@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
- Coverage 76.2% 76.2% -0.1%
=======================================
Files 179 179
Lines 11939 11940 +1
=======================================
- Hits 9103 9102 -1
- Misses 2596 2598 +2
Partials 240 240
| Impacted Files | Coverage Δ | |
|---|---|---|
| bridge/opentracing/bridge.go | 62.3% <100.0%> (+<0.1%) |
:arrow_up: |
| exporters/jaeger/jaeger.go | 90.3% <0.0%> (-0.9%) |
:arrow_down: |
Seems like the CLA is not signed yet, could you pls check again and fix it? @Prajithp
@hanyuancheung Tried multiple times by signing the Doc. After clicking the Finish button, page is redirecting back to Github without any messages