otelmongo#39 Use a mock deployment for testing against a MongoDB server

[prestonvasquez]

trafficstars

Resolves #39

Use mtest to mock a mongodb deployment.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.5%. Comparing base (2a72871) to head (dd36791). Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #5749     +/-   ##
=======================================
+ Coverage   65.8%   66.5%   +0.7%     
=======================================
  Files        205     205             
  Lines      13097   13093      -4     
=======================================
+ Hits        8618    8708     +90     
+ Misses      4215    4118     -97     
- Partials     264     267      +3     

see 5 files with indirect coverage changes

[dmathieu]

We discussed the licensing issue during the SIG meeting on thursday, and I brought the question to the #otel-maintainers slack channel.

What it seems other languages are doing is include both licenses, the original one as well as the OpenTelemetry one. See java-instrumentation, or the collector.

Would having something similar work for you?

[prestonvasquez]

We discussed the licensing issue during the SIG meeting on thursday, and I brought the question to the #otel-maintainers slack channel.

What it seems other languages are doing is include both licenses, the original one as well as the OpenTelemetry one. See java-instrumentation, or the collector.

Would having something similar work for you?

@blink1073 @matthewdale Do you have thoughts on this? This PR proposes copying code from opmsg_deployment.go to mock a server for testing. The ask is that we include both our license as well as the OpenTelemetry license in that copy.

Alternatively, we could use mtest. The problems with this solution are described in this PR here. However, it would resolve both this issue and a requirement to test the mock deployment.

[blink1073]

The ask is that we include both our license as well as the OpenTelemetry license in that copy.

If possible, I'd recommend keeping the original LICENSE and adding a THIRD-PARTY-NOTICES file.

[jtazin]

Hi @dmathieu @pellared @MrAlias, @prestonvasquez has reworked the code to import mtest in order to satisfy both OpenTelemetry's and MongoDB's licensing requirements. Could you please take a look and let us know if it looks good to you?

[jtazin]

@pellared could you please take a look at Preston's latest changes? let us know if anything else is needed!

[pellared]

@prestonvasquez, can you sync the branch with main?

@open-telemetry/go-approvers, last call for review. I plan to merge this PR tomorrow unless nobody adds comments.