open-telemetry
Jaeger Propagator: Fix accepting short trace and span IDs
Fixes #2729.
While implementing the fix for trace IDs, i noticed that span IDs have the same requirement, so I fixed them as well.
As an optimization, we could keep the special case for 64-bit tracing IDs with a constant padding. I'm not sure it's worth it, so I haven't implemented this for now.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: mfrister / name: M. Frister (2bb5c692ff8d8e4d4b296408089d8884004495b1, 5d93e04d07e80bcad85a67f9dd04f22dccf71c71)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #2731 (68bf034) into main (4e0d97e) will decrease coverage by
0.0%. The diff coverage is100.0%.
Additional details and impacted files
@@ Coverage Diff @@
## main #2731 +/- ##
=======================================
- Coverage 69.4% 69.3% -0.1%
=======================================
Files 145 145
Lines 6707 6712 +5
=======================================
+ Hits 4655 4657 +2
- Misses 1938 1940 +2
- Partials 114 115 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| propagators/jaeger/jaeger_propagator.go | 97.3% <100.0%> (+0.1%) |
:arrow_up: |
| samplers/jaegerremote/sampler_remote.go | 85.4% <0.0%> (-2.0%) |
:arrow_down: |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mfrister Could you please sign the CLA?
Sure, I'm already working on it. Will need a corporate CLA, so this might take a few days.