Conform attributes and span name to v1.27 semantics for OpentelemetryTesla

[ShapovalovaIrina]

Conform attributes and span name to v1.27 semantics for OpentelemetryTesla.

Follows the guidelines set out in https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/http/http-spans.md.

Changed

Span name

• Span name {custom} changed to {method} {custom}
• Span name HTTP {method} changed to {method}
• Span name {template} changed to {method} {template}

Required attributes

• Set error.type attribute when span status is error
• Rename attribute http.method -> http.request.method
• Rename attribute http.url -> url.full
• Rename attribute http.status_code -> http.response.status_code
• Rename attribute net.host.name -> server.address

Opt-in attributes

• Rename attribute http.scheme -> url.scheme
• Rename attribute http.response.content.length -> http.response.body.size

Added

Required attributes

• Add attribute server.port

Opt-in attributes

• Add attribute http.request.body.size
• Add attribute network.transport
• Add attribute url.template
• Add attribute user.agent.original
• Add attribute http.request.header.<key>
• Add attribute http.request.header.<key>

The presence of opt-in attributes is configured using options:

• :opt_in_attrs
• :request_header_attrs
• :response_header_attrs

Removed

• Remove attribute http.target

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: ShapovalovaIrina / name: Irina Shapovalova (31103fed4b7ae566e1ea4bb7e5d84f4c2d5346c5, 281e729abeae49a3ba714bc952af881a3dcab79b, 280d350a734e744e7ec8a40d9153d771486667fe)
• :white_check_mark: login: tsloughter / name: Tristan Sloughter (adae7416e63e865f556397291f6b07fb79db3a93, 5295ec1ac0c941db879c4f40b1f8b55cb2a6ffb1)

[bryannaegele]

Can you please refer to the updates to Req for all the appropriate API changes that need to be implemented here?

Same things would apply to Finch, as well.

Thanks!

[ShapovalovaIrina]

Can you please refer to the updates to Req for all the appropriate API changes that need to be implemented here?

Just to clarify, are you talking about changes in https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/375?

[ShapovalovaIrina]

@bryannaegele made changes to Tesla and Finch referring to Req updates. Will be waiting for feedback :)

[ShapovalovaIrina]

@ricardoccpaiva Hello! Sorry to bother you, but as far as I understand you are the codeowner of the opentelemetry_tesla, so could you please leave some feedback on the PR?

[ShapovalovaIrina]

Hello @bryannaegele and @ricardoccpaiva, I’m not sure who’s the right person to review this, but if either of you has time, I’d be grateful for your input. Let me know if I should ask someone else instead. Thank you! 🙂

[hoyon]

Sorry to nudge but is there any update on this PR? The current version of opentelemetry_tesla depends on opentelemetry_semantic_conventions ~> 0.2 which makes it difficult to use with other otel libraries which already depend on ~> 1.27 without resorting to using an override.

[tsloughter]

@hoyon no worries. I think we can probably get this one merged in soon. I need to double check some things. Hopefully tomorrow unless its decided some options need to change or be added around the attributes included.

[hoyon]

@tsloughter Thanks for merging this PR! Can a new release be created for this change please?

[ShapovalovaIrina]

Thanks for merging PR :)

Do you have any updates about a new release with these changes?