opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

🐛 Fix OpentelemetryFinch handler on Finch.stream_while

Open rparcus opened this issue 1 year ago • 5 comments

Fixes https://github.com/open-telemetry/opentelemetry-erlang-contrib/issues/327

rparcus avatar Oct 18 '24 19:10 rparcus

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: rparcus / name: Robert Parcus (91808de09d14069ad17c2e4b2d611adc50325eb2, fb5d2d19e1b939f8a9ef332120d9c050d7081718, 7e0208c45fef4a51c55d5d327816ed513060a102, 9ac5b88376adf87808c7028cb3f3223abf9eab9b, 2fac77e015b152e3dca5f8c716572ebc5fbf6969)

Hello 👋 Without this fix it is impossible to instrument anything that uses streaming + finch. Is there anything I can do to further help with the review process?

rparcus avatar Nov 20 '24 06:11 rparcus

+1 for this PR.

We are using the Langchain lib with streams, and it is not compatible with OTEL.

lud-wj avatar Dec 02 '24 18:12 lud-wj

Thanks for the suggestion above. I think it's great @lud-wj. Done in 9ac5b88

+1 for this PR.

We are using the Langchain lib with streams, and it is not compatible with OTEL.

That is exactly why this PR exists ✨

rparcus avatar Dec 03 '24 04:12 rparcus

Would be nice to have this merged 🙏

gmile avatar Jan 08 '25 15:01 gmile

@bryannaegele, it seems you've been reviewing and merging the opentelemetry_finch PRs in this repo. Any chance you could review this one too? 🙏 Thank you in advance!

maxdrift avatar Jun 19 '25 15:06 maxdrift