opentelemetry-erlang-contrib
opentelemetry-erlang-contrib copied to clipboard
🐛 Fix OpentelemetryFinch handler on Finch.stream_while
Fixes https://github.com/open-telemetry/opentelemetry-erlang-contrib/issues/327
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: rparcus / name: Robert Parcus (91808de09d14069ad17c2e4b2d611adc50325eb2, fb5d2d19e1b939f8a9ef332120d9c050d7081718, 7e0208c45fef4a51c55d5d327816ed513060a102, 9ac5b88376adf87808c7028cb3f3223abf9eab9b, 2fac77e015b152e3dca5f8c716572ebc5fbf6969)
Hello 👋 Without this fix it is impossible to instrument anything that uses streaming + finch. Is there anything I can do to further help with the review process?
+1 for this PR.
We are using the Langchain lib with streams, and it is not compatible with OTEL.
Thanks for the suggestion above. I think it's great @lud-wj. Done in 9ac5b88
+1 for this PR.
We are using the Langchain lib with streams, and it is not compatible with OTEL.
That is exactly why this PR exists ✨
Would be nice to have this merged 🙏
@bryannaegele, it seems you've been reviewing and merging the opentelemetry_finch PRs in this repo. Any chance you could review this one too? 🙏
Thank you in advance!