opentelemetry-dotnet-contrib icon indicating copy to clipboard operation
opentelemetry-dotnet-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Fix null tags.

Open SebastianStehle opened this issue 3 years ago • 1 comments

Fixes #565

Changes

  • Convert null tags to correct attribute value.
  • Fix tests, which were not using the correct activities.
  • Fix an edge case where an invalid activity would throw exceptions in the exporter.

SebastianStehle avatar Aug 08 '22 08:08 SebastianStehle

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: SebastianStehle / name: Sebastian Stehle (a10890ecee830897858dc6ea84bc122a97ca31ac)

linux-foundation-easycla[bot] avatar Aug 08 '22 08:08 linux-foundation-easycla[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Aug 17 '22 03:08 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Aug 24 '22 03:08 github-actions[bot]

Please reopen

SebastianStehle avatar Aug 24 '22 05:08 SebastianStehle

Please resolve the merge conflicts.

utpilla avatar Aug 24 '22 05:08 utpilla

Of course, have not seen that.

SebastianStehle avatar Aug 24 '22 10:08 SebastianStehle

Conflicts are solved.

SebastianStehle avatar Aug 24 '22 12:08 SebastianStehle

Codecov Report

Merging #566 (a976ccf) into main (bf01da1) will increase coverage by 1.05%. The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   76.70%   77.76%   +1.05%     
==========================================
  Files         170      170              
  Lines        5161     5163       +2     
==========================================
+ Hits         3959     4015      +56     
+ Misses       1202     1148      -54
Impacted Files Coverage Δ
...r.Stackdriver/Implementation/ActivityExtensions.cs 71.05% <0.00%> (+71.05%) :arrow_up:
...y.Exporter.Stackdriver/StackdriverTraceExporter.cs 67.50% <100.00%> (+3.39%) :arrow_up:

codecov[bot] avatar Aug 24 '22 16:08 codecov[bot]

Please fix the failing CI task as well.

utpilla avatar Aug 25 '22 15:08 utpilla

@SergeyKanzhelev Could you please review this PR?

utpilla avatar Aug 25 '22 15:08 utpilla

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Sep 02 '22 04:09 github-actions[bot]

I think it is a critical bug and it would be great if it can be merged asap

SebastianStehle avatar Sep 02 '22 06:09 SebastianStehle

@SebastianStehle Please add a CHANGELOG entry. After you have done that, if you would like a new version for the package released, please follow the steps mentioned here: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

utpilla avatar Sep 06 '22 18:09 utpilla