opentelemetry-cpp
opentelemetry-cpp copied to clipboard
open-telemetry
dynamically generate curl header file with macro if curl installed
Based on comment here:
https://github.com/open-telemetry/opentelemetry-cpp/pull/445#discussion_r542216350
Instead of defining macro for all the cpp source files which use curl based http client, it's suggested to instead automatically generate/update the header file for WITH_CURL macro, and ensure we include this header file wherever needed.
Note: There's also an aspect of the BAZEL build where it'd be ideal if we had a header file that included the necessary -D. See #444 for an example in bazel where libraries using CURL need to add the defines.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
@lalitb The issue originally reported seem out of date now.
Could this be closed ?
@lalitb The issue originally reported seem out of date now.
Could this be closed ?
Yes I think this can be closed now.