opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Use `nostd::enable_if_t` instead of `std::enable_if_t`

Open owent opened this issue 1 year ago • 5 comments
trafficstars

Fixes #2647

Changes

Please provide a brief description of the changes here.

  • Use nostd::enable_if_t instead of std::enable_if_t

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [x] Changes in public API reviewed

owent avatar Apr 26 '24 06:04 owent

The failed job report error when compiling upb, which seems not a problem of this PR?

owent avatar Apr 26 '24 09:04 owent

The failed job report error when compiling upb, which seems not a problem of this PR?

Looks like we need to upgrade com_google_absl. Probably something changed in macos-latest (clang version?) recently which triggered this.

lalitb avatar Apr 26 '24 19:04 lalitb

This PR looks ok.

The build failure on MacOS seems unrelated, and to fix separately.

marcalff avatar Apr 26 '24 20:04 marcalff

This PR looks ok.

The build failure on MacOS seems unrelated, and to fix separately.

Curious on what triggered the MacOS build warning.

ThomsonTan avatar Apr 26 '24 20:04 ThomsonTan

Curious on what triggered the MacOS build warning.

My guess is that XCode update on mac-os14 (which is macos-latest) triggered clang to get updated too.

https://github.com/actions/runner-images/pull/9726

lalitb avatar Apr 26 '24 21:04 lalitb