opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[NFC] Improve scope/instrument names in metrics ostream exporter

Open bsarden opened this issue 3 years ago • 1 comments

Previously, we were overloading the name key in the metrics ostream exporter. This patch qualifies the name key with the appropriate prefix based on the structures they represent.

bsarden avatar Aug 06 '22 20:08 bsarden

Codecov Report

Merging #1544 (0170a63) into main (b4ed047) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files         156      156           
  Lines        4908     4908           
=======================================
  Hits         4119     4119           
  Misses        789      789           
Impacted Files Coverage Δ
exporters/ostream/test/ostream_metric_test.cc 100.00% <ø> (ø)
exporters/ostream/src/metric_exporter.cc 92.13% <100.00%> (ø)

codecov[bot] avatar Aug 06 '22 20:08 codecov[bot]