opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[METRICS SDK] Fix OTLP gRPC Metrics env variables

Open lalitb opened this issue 3 years ago • 1 comments

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

otlp gRPC Metrics exporter is reusing the env variable processing from otlp trace exporter, which is making it use env variables containing _TRACE_ instead of _METRICS_. This is fixed now.

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

lalitb avatar Aug 05 '22 22:08 lalitb

Codecov Report

Merging #1543 (aa07289) into main (8b61c99) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1543   +/-   ##
=======================================
  Coverage   83.91%   83.91%           
=======================================
  Files         156      156           
  Lines        4908     4908           
=======================================
  Hits         4118     4118           
  Misses        790      790           

codecov[bot] avatar Aug 05 '22 22:08 codecov[bot]