opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Fix default Metric view name

Open esigo opened this issue 3 years ago • 1 comments

Fixes #1510 (issue)

Changes

when the view is not registered, creates and registers a new view with the provided information.

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

esigo avatar Jul 24 '22 14:07 esigo

Codecov Report

Merging #1515 (9e74e43) into main (ba1cd0d) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
+ Coverage   83.85%   83.91%   +0.07%     
==========================================
  Files         156      156              
  Lines        4908     4908              
==========================================
+ Hits         4115     4118       +3     
+ Misses        793      790       -3     
Impacted Files Coverage Δ
...ude/opentelemetry/sdk/metrics/view/view_registry.h 93.75% <100.00%> (ø)
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) :arrow_up:

codecov[bot] avatar Jul 24 '22 14:07 codecov[bot]