opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

Remove LogName argument as deprecated from Logger API

Open lalitb opened this issue 3 years ago • 5 comments
trafficstars

To be added

lalitb avatar Jun 01 '22 16:06 lalitb

Are we going to remove LogName in next release?

owent avatar Jun 02 '22 02:06 owent

Not necessarily the next release, but we need to do it eventually based on bandwidth. This issue is to track the cleanup.

lalitb avatar Jun 02 '22 02:06 lalitb

@owent as removing logger name is a breaking change for logging, I suggest we don't ship it in the same release of the release candidate of OpenTelemetry metrics. So we either make the change in the release this month (the current plan is releasing metrics candidate in July), or make the change after the metrics release candidate. @owent, any recommendation on this?

ThomsonTan avatar Jun 06 '22 20:06 ThomsonTan

@owent as removing logger name is a breaking change for logging, I suggest we don't ship it in the same release of the release candidate of OpenTelemetry metrics. So we either make the change in the release this month (the current plan is releasing metrics candidate in July), or make the change after the metrics release candidate. @owent, any recommendation on this?

I vote for make the change after the metrics release candidate.

owent avatar Jun 07 '22 02:06 owent

This issue was marked as stale due to lack of activity.

github-actions[bot] avatar Aug 07 '22 02:08 github-actions[bot]

This issue is solved by #1884

owent avatar May 25 '23 06:05 owent