make sure ci job uses always the latest go patch available

[cpanato]

trafficstars

Description:

• make sure ci job uses always the latest go patch available
• update deprecated goreleaser flag

[cpanato]

cc @jpkrohling

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.75%. Comparing base (0d6e6bf) to head (0149ba7).

:exclamation: Current head 0149ba7 differs from pull request most recent head e99f986

Please upload reports for the commit e99f986 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9951      +/-   ##
==========================================
- Coverage   92.56%   91.75%   -0.81%     
==========================================
  Files         387      358      -29     
  Lines       18254    16569    -1685     
==========================================
- Hits        16896    15203    -1693     
- Misses       1014     1038      +24     
+ Partials      344      328      -16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[TylerHelmuth]

If I recall correctly I purposefully switch from using the latest patch version to specifying a specific patch version so that we had complete control over the go version we built/tested with

[cpanato]

purposefully switch from using the latest patch version to spe

I see, but then should we pin that to the patch version and not use the ~?

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions[bot]]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

[cpanato]

@jpkrohling @TylerHelmuth is this something you guys want to have? if yes can you reopen and lets merge it?

[jpkrohling]

I think this is desirable, especially for the security aspects of this, but I'll let @TylerHelmuth comment as well. I understand that this is either about using the latest patch, or pinning to specific patch (and thus, remove ~ from the version spec), right?

[cpanato]

i will rebase and fix the conflicts

[TylerHelmuth]

Agreed

[cpanato]

@jpkrohling @TylerHelmuth done, ptal

thanks!

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[jpkrohling]

I asked the Collector leads if it's something we want, and if so, I'll fix the conflicts.

[cpanato]

rebased

[codeboten]

I don't see why we shouldn't do this, although one thing to keep in mind is that CI will be broken when a new version of go is released (because of the helpful toolchain directive)

[jpkrohling]

Can't renovate take care of bumping it as well?

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[cpanato]

renovate or dependabot can bump

[mx-psi]

renovate or dependabot can bump

Is this something we have an issue/PR for?

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions[bot]]

Closed as inactive. Feel free to reopen if this PR is still being worked on.