opentelemetry-collector
opentelemetry-collector copied to clipboard
[configgrpc] Clean up the logic associated with https endpoints
Description: This PR changes the logic associated with https endpoints handling to make it more obvious that it is overriding TLS settings. It keeps all other TLS settings rather than disposing of them. It adds a warning to let the user know that they have a conflicting configuration if they both set the insecure flag to true and use a https endpoint.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.39%. Comparing base (
ea5aa62) to head (a5492f4). Report is 185 commits behind head on main.
:exclamation: Current head a5492f4 differs from pull request most recent head 10e605f. Consider uploading reports for the commit 10e605f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #9537 +/- ##
==========================================
- Coverage 90.89% 90.39% -0.50%
==========================================
Files 347 346 -1
Lines 18325 18208 -117
==========================================
- Hits 16656 16460 -196
- Misses 1344 1416 +72
- Partials 325 332 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.