opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[confmap] Restrict characters in environment variable URIs even more!

Open mx-psi opened this issue 1 year ago • 0 comments
trafficstars

In #5706, we discussed restricting URIs in characters for all providers. We ended up disallowing $ in #6268 for the recursive implementation done later.

I think we should restrict the character set even more for the env provider, in particular by following the restrictions defined by the OpenTelemetry Configuration Working Group (see here). While, as mentioned in https://github.com/open-telemetry/opentelemetry-collector/issues/5706#issuecomment-1189909801, there are more characters allowed on both Windows and Linux, the set of environment variable names allowed by the spec is reasonable and (pressumably!) what the vast majority of users use.

We should probably restrict it also on the expandconverter while it exists

mx-psi avatar Feb 08 '24 16:02 mx-psi