opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[confignet] Should we change the name of `NetAddr` and `NetTCP` to end in `Config`?

Open mx-psi opened this issue 1 year ago • 2 comments 

          Few others:
  • NetAddr -> AddrConfig?
  • NetTCP -> TCPConfig?

Originally posted by @bogdandrutu in https://github.com/open-telemetry/opentelemetry-collector/issues/9474#issuecomment-1930426896

mx-psi avatar Feb 07 '24 09:02 mx-psi

Also we duplicate the "net" prefix in config[net].[Net]Addr for example

bogdandrutu avatar Feb 07 '24 17:02 bogdandrutu

Taking this up.

NetTCP -> TCPConfig?

@bogdandrutu I am assuming, by this you mean TCPAddr ? https://github.com/open-telemetry/opentelemetry-collector/blob/de6287de839a7d2c0273dd1df3a064a08f733904/config/confignet/confignet.go#L48-L49

EDIT: Nevermind. I missed the PR that already addresses this.

arjunmahishi avatar Feb 10 '24 05:02 arjunmahishi

Requires https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31354

TylerHelmuth avatar Feb 20 '24 18:02 TylerHelmuth