opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[configgrpc] Remove `ServerConfig.ToListener` and `ToListenerContext`?

Open mx-psi opened this issue 1 year ago • 3 comments

This option is redundant since one can already call ServerConfig.NetAddr.Listen instead. Should we deprecate it?

mx-psi avatar Feb 06 '24 13:02 mx-psi

+1, agree.

bogdandrutu avatar Feb 06 '24 17:02 bogdandrutu

Also, as a general rule all these "ToFoo" should have options in the signature for future proof and very important Context as first argument.

bogdandrutu avatar Feb 06 '24 17:02 bogdandrutu

Also, as a general rule all these "ToFoo" should have options in the signature for future proof and very important Context as first argument.

Split off at #9490

mx-psi avatar Feb 07 '24 09:02 mx-psi