opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[exporter/nopexporter] Add the nopexporter

Open evan-bradley opened this issue 1 year ago • 1 comments
trafficstars

Description:

Add the nopexporter. This can be helpful if a user wants to start the Collector with a dummy pipeline to only enable extensions. It could also be used to test Collector pipeline throughput.

Link to tracking Issue:

Resolves https://github.com/open-telemetry/opentelemetry-collector/issues/7316

Testing:

Added lifecycle tests; the receiver doesn't do anything.

Documentation:

Added a readme for the component.

cc @djaglowski @tigrannajaryan

evan-bradley avatar Jan 31 '24 19:01 evan-bradley

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.93%. Comparing base (2413346) to head (99b2cf7).

Files Patch % Lines
.../nopexporter/internal/metadata/generated_status.go 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9448      +/-   ##
==========================================
- Coverage   90.95%   90.93%   -0.02%     
==========================================
  Files         350      352       +2     
  Lines       18576    18591      +15     
==========================================
+ Hits        16895    16906      +11     
- Misses       1354     1358       +4     
  Partials      327      327              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 20:01 codecov[bot]

My only bikeshed would be nop vs noop but both are acceptable spellings.

I would prefer noop myself, but it seems like nop is more conventional in Go and within the Collector. If others feel the same way, I'm open to changing the name.

evan-bradley avatar Feb 13 '24 18:02 evan-bradley

My only bikeshed would be nop vs noop but both are acceptable spellings.

I would prefer noop myself, but it seems like nop is more conventional in Go and within the Collector. If others feel the same way, I'm open to changing the name.

+1 to nop. One less character.

tigrannajaryan avatar Feb 13 '24 20:02 tigrannajaryan

@evan-bradley please run make gogenerate to make CI green

dmitryax avatar Mar 07 '24 22:03 dmitryax

@dmitryax Took a bit of tweaking. Should be good to go now.

evan-bradley avatar Mar 10 '24 23:03 evan-bradley