opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[chore] validate version format to prepare-release workflow

Open Sanket-0510 opened this issue 1 year ago • 2 comments
trafficstars

Description: <Describe what has changed.> enhance the "Automation - Prepare Release" GitHub Actions workflow by adding version format validation. The workflow now includes a new job, "validate-version," which checks whether the provided version inputs match the expected schema

Link to tracking Issue: <Issue number if applicable> #7627

Sanket-0510 avatar Jan 27 '24 18:01 Sanket-0510

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.60%. Comparing base (cc88aee) to head (a16d3e7). Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9409      +/-   ##
==========================================
+ Coverage   90.58%   90.60%   +0.01%     
==========================================
  Files         347      347              
  Lines       18247    18247              
==========================================
+ Hits        16529    16532       +3     
+ Misses       1388     1386       -2     
+ Partials      330      329       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 08:01 codecov[bot]

@TylerHelmuth the review is stale from last week, could you please review the PR. I think I have covered all the aspects, do let me know if any further changes required, regards, Sanket

Sanket-0510 avatar Feb 06 '24 14:02 Sanket-0510

@anuraaga @TylerHelmuth if this is good enough will you please consider this for merging, it's been stale from the last 2 weeks.

Regards, Sanket

Sanket-0510 avatar Feb 29 '24 21:02 Sanket-0510

@open-telemetry/collector-maintainers please take a look.

TylerHelmuth avatar Feb 29 '24 21:02 TylerHelmuth

Will test this on Monday's release :)

mx-psi avatar Mar 01 '24 10:03 mx-psi

Looks like there is some sort of issue: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/8110269766/workflow @Sanket-0510 could you have a look?

mx-psi avatar Mar 01 '24 10:03 mx-psi

Looks like there is some sort of issue: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/8110269766/workflow @Sanket-0510 could you have a look?

there is an intendation issue i guess https://github.com/open-telemetry/opentelemetry-collector/blob/94b5951a3ec9526765bd631728d4f7fe12fad6bd/.github/workflows/prepare-release.yml#L27C1-L32C1

@mx-psi I will open a PR to fix this.

Sanket-0510 avatar Mar 01 '24 11:03 Sanket-0510