[scraperhelper] Deprecate ScraperControllerSettings, use ControllerConfig instead

[atoulme]

Description: Deprecate ScraperControllerSettings, use ~Scraper~ControllerConfig instead

Link to tracking Issue: #6767

[codecov[bot]]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (59b45a5) 90.61% compared to head (04e5c8b) 90.60%.

Files	Patch %	Lines
receiver/scraperhelper/config.go	60.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9401      +/-   ##
==========================================
- Coverage   90.61%   90.60%   -0.01%     
==========================================
  Files         347      347              
  Lines       18236    18238       +2     
==========================================
  Hits        16525    16525              
- Misses       1381     1383       +2     
  Partials      330      330              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bogdandrutu]

Please rebase

[atoulme]

Rebased. One more thing. The signature is:

func NewDefaultControllerConfig(component.Type) ControllerConfig {

However, the parameter component.Type is not used. Should we remove it?

[bogdandrutu]

However, the parameter component.Type is not used. Should we remove it?

Please

[atoulme]

Done, it's removed.