opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[exporterhelper] Introduce batching functionality

Open dmitryax opened this issue 2 years ago • 2 comments
trafficstars

This change introduces new experimental batching functionality to the exporter helper. The batch sender is fully concurrent and synchronous. It's set after the queue sender, which, if enabled, introduces the asynchronous behavior and ensures no data loss with the permanent queue.

Follow-up TODO list:

  • Handle partial errors
  • A missing part compared to the batch processor is the ability to shard the batches by context value.

Updates https://github.com/open-telemetry/opentelemetry-collector/issues/8122

dmitryax avatar Oct 16 '23 06:10 dmitryax

Codecov Report

Attention: Patch coverage is 93.18182% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 90.95%. Comparing base (2fe7ed8) to head (8c83fd7).

Files Patch % Lines
exporter/exporterhelper/batch_sender.go 95.16% 4 Missing and 2 partials :warning:
exporter/exporterhelper/common.go 79.31% 4 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8685      +/-   ##
==========================================
+ Coverage   90.92%   90.95%   +0.02%     
==========================================
  Files         348      350       +2     
  Lines       18401    18576     +175     
==========================================
+ Hits        16732    16895     +163     
- Misses       1346     1354       +8     
- Partials      323      327       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 16 '23 06:10 codecov[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jan 06 '24 03:01 github-actions[bot]