opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Remove configuration for otelcorecol

Open jpkrohling opened this issue 3 years ago • 2 comments

Verify that the default config file matches the one we use for otelcorecol. If so, remove the config from the repository to rely on the default one.

Originally posted by @bogdandrutu in https://github.com/open-telemetry/opentelemetry-collector/pull/6075#discussion_r970886635

jpkrohling avatar Sep 14 '22 15:09 jpkrohling

The embedded default config for ocb doesn't have the "replaces" directives because in that case ocb could be running from anywhere. When you generate otelcorecol, you want the "replaces" because you know that you are building in a multi-module repo, and you want to use the local modules.

jpeach avatar Sep 14 '22 23:09 jpeach

I had this suspicion and wanted to confirm this before committing to removing the config. Thanks for confirming this, looks like we should either keep the config or patch it. I would personally prefer to keep the config.

jpkrohling avatar Sep 15 '22 13:09 jpkrohling

It looks like work is completed. Can we close the issue?

atoulme avatar Dec 14 '23 07:12 atoulme