opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Deprecate exporterhelper.New*Exporter in favor of New*ExporterWithContest

Open bogdandrutu opened this issue 3 years ago • 1 comments
trafficstars

Main motivation is to pass the context to the helper in case any cancelation is needed, and to match the Create[*]Exporter calls.

Signed-off-by: Bogdan [email protected]

bogdandrutu avatar Aug 05 '22 18:08 bogdandrutu

Codecov Report

Merging #5834 (5816b1f) into main (4fc69ef) will decrease coverage by 0.06%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #5834      +/-   ##
==========================================
- Coverage   91.67%   91.61%   -0.07%     
==========================================
  Files         195      195              
  Lines       11931    11912      -19     
==========================================
- Hits        10938    10913      -25     
- Misses        783      789       +6     
  Partials      210      210              
Impacted Files Coverage Δ
exporter/exporterhelper/logs.go 81.96% <0.00%> (-2.78%) :arrow_down:
exporter/exporterhelper/metrics.go 81.96% <0.00%> (-2.78%) :arrow_down:
exporter/loggingexporter/logging_exporter.go 80.00% <ø> (-8.30%) :arrow_down:
exporter/exporterhelper/traces.go 83.87% <50.00%> (-3.02%) :arrow_down:
exporter/loggingexporter/factory.go 100.00% <100.00%> (ø)
exporter/otlpexporter/factory.go 90.90% <100.00%> (-0.76%) :arrow_down:
exporter/otlphttpexporter/factory.go 86.95% <100.00%> (-0.80%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 18:08 codecov[bot]