Deprecate processorhelper.New*Processor in favor of New*ProcessorWithCreateSettings

[bogdandrutu]

trafficstars

Main motivation is to ensure that Settings are passed (to enable obsreport usage which requires settings to be passed) as well as the context.

Signed-off-by: Bogdan [email protected]

[codecov[bot]]

Codecov Report

Merging #5833 (45348c1) into main (4fc69ef) will decrease coverage by 0.04%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5833      +/-   ##
==========================================
- Coverage   91.67%   91.62%   -0.05%     
==========================================
  Files         195      195              
  Lines       11931    11934       +3     
==========================================
- Hits        10938    10935       -3     
- Misses        783      789       +6     
  Partials      210      210              

Impacted Files	Coverage Δ
processor/processorhelper/logs.go	84.37% <66.66%> (-5.29%)	:arrow_down:
processor/processorhelper/metrics.go	84.37% <66.66%> (-5.29%)	:arrow_down:
processor/processorhelper/traces.go	84.37% <66.66%> (-5.29%)	:arrow_down:
processor/memorylimiterprocessor/factory.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bogdandrutu]

@dmitryax I don't feel is that significant, since we are making the "helper" funcs to look like the Factory funcs (which are the significant once. But more eyes are always welcome.

[bogdandrutu]

Per the approvers from https://github.com/open-telemetry/opentelemetry-collector/pull/5834 I take that this is fine as well

[jpkrohling]

I haven't reviewed this code in detail, but the general approach is fine.