opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Allow user to pass in metrics namespace

Open splunkericl opened this issue 3 years ago • 3 comments
trafficstars

Description:
Adding a configuration that allows user to configure their metrics namespace

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector/issues/5692

Testing: Added a unit test to verify namespace can be customized

Documentation: Added godoc on the new namespace field

splunkericl avatar Jul 28 '22 22:07 splunkericl

Codecov Report

Merging #5758 (15f2fe3) into main (b463d2a) will decrease coverage by 0.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5758      +/-   ##
==========================================
- Coverage   91.78%   91.62%   -0.16%     
==========================================
  Files         192      192              
  Lines       11394    11429      +35     
==========================================
+ Hits        10458    10472      +14     
- Misses        742      763      +21     
  Partials      194      194              
Impacted Files Coverage Δ
service/telemetry.go 89.51% <100.00%> (+0.30%) :arrow_up:
exporter/exporterhelper/queued_retry_inmemory.go 79.34% <0.00%> (-12.55%) :arrow_down:
pdata/internal/metrics.go 87.76% <0.00%> (-4.74%) :arrow_down:
component/exporter.go 100.00% <0.00%> (ø)
component/receiver.go 100.00% <0.00%> (ø)
component/processor.go 100.00% <0.00%> (ø)
pdata/internal/generated_pmetric.go 97.38% <0.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b463d2a...15f2fe3. Read the comment docs.

codecov[bot] avatar Jul 28 '22 22:07 codecov[bot]

Issue description is bit confusing. Can you please reply to https://github.com/open-telemetry/opentelemetry-collector/issues/5692#issuecomment-1201571189

dmitryax avatar Aug 01 '22 18:08 dmitryax

@dmitryax @TylerHelmuth any other comments or good to merge?

tigrannajaryan avatar Aug 02 '22 18:08 tigrannajaryan

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 17 '22 03:08 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Aug 31 '22 04:08 github-actions[bot]