opentelemetry-collector
opentelemetry-collector copied to clipboard
add validation for empty telemetry metric address when level not none
Signed-off-by: Ziqi Zhao [email protected]
Description: <Describe what has changed. Fix #5655
Codecov Report
Base: 91.82% // Head: 92.00% // Increases project coverage by +0.18% :tada:
Coverage data is based on head (
176c8b3) compared to base (07603a0). Patch coverage: 91.17% of modified lines in pull request are covered.
:exclamation: Current head 176c8b3 differs from pull request most recent head 4459272. Consider uploading reports for the commit 4459272 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #5661 +/- ##
==========================================
+ Coverage 91.82% 92.00% +0.18%
==========================================
Files 237 218 -19
Lines 13549 13336 -213
==========================================
- Hits 12441 12270 -171
+ Misses 882 836 -46
- Partials 226 230 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| config/moved_config.go | 96.51% <88.88%> (ø) |
|
| service/telemetry/config.go | 100.00% <100.00%> (ø) |
|
| exporter/loggingexporter/config.go | 0.00% <0.00%> (-64.52%) |
:arrow_down: |
| pdata/internal/wrapper_metrics.go | 52.17% <0.00%> (-47.83%) |
:arrow_down: |
| service/servicetest/configprovider.go | 53.84% <0.00%> (-22.16%) |
:arrow_down: |
| service/flags.go | 80.76% <0.00%> (-19.24%) |
:arrow_down: |
| pdata/pcommon/traceid.go | 81.81% <0.00%> (-18.19%) |
:arrow_down: |
| pdata/pmetric/metrics.go | 88.04% <0.00%> (-11.96%) |
:arrow_down: |
| pdata/ptrace/traces.go | 80.64% <0.00%> (-11.36%) |
:arrow_down: |
| receiver/otlpreceiver/config.go | 84.00% <0.00%> (-10.45%) |
:arrow_down: |
| ... and 90 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@bogdandrutu @jpkrohling @TylerHelmuth All checks are passed, please help review this again, thanks, =D
@bogdandrutu I think the failed check is not related to this pr.
PR rebased.
PR rebased.
Done
The CI is failing due to https://github.com/open-telemetry/opentelemetry-collector/issues/5770
The CI is failing due to #5770
Done
ping @jpkrohling, could you review this again?
unittest (1.19) didn't complete yet, PR rebased to see if this check is triggered.
@jpkrohling unittest for 1.19 is triggered and passed =D
ping @jpkrohling for review this again, thx, =D
Sorry, I was out last week. Could you please rebase this? There seems to be a conflict that needs solving.
Sorry, I was out last week. Could you please rebase this? There seems to be a conflict that needs solving.
I already rebased this =D @jpkrohling
Could you review this again? @jpkrohling
@bogdandrutu, you had comments on this before as well, do you want to review it again?
ping @bogdandrutu @jpkrohling