opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

add validation for empty telemetry metric address when level not none

Open fatsheep9146 opened this issue 3 years ago • 16 comments
trafficstars

Signed-off-by: Ziqi Zhao [email protected]

Description: <Describe what has changed. Fix #5655

fatsheep9146 avatar Jul 09 '22 16:07 fatsheep9146

Codecov Report

Base: 91.82% // Head: 92.00% // Increases project coverage by +0.18% :tada:

Coverage data is based on head (176c8b3) compared to base (07603a0). Patch coverage: 91.17% of modified lines in pull request are covered.

:exclamation: Current head 176c8b3 differs from pull request most recent head 4459272. Consider uploading reports for the commit 4459272 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5661      +/-   ##
==========================================
+ Coverage   91.82%   92.00%   +0.18%     
==========================================
  Files         237      218      -19     
  Lines       13549    13336     -213     
==========================================
- Hits        12441    12270     -171     
+ Misses        882      836      -46     
- Partials      226      230       +4     
Impacted Files Coverage Δ
config/moved_config.go 96.51% <88.88%> (ø)
service/telemetry/config.go 100.00% <100.00%> (ø)
exporter/loggingexporter/config.go 0.00% <0.00%> (-64.52%) :arrow_down:
pdata/internal/wrapper_metrics.go 52.17% <0.00%> (-47.83%) :arrow_down:
service/servicetest/configprovider.go 53.84% <0.00%> (-22.16%) :arrow_down:
service/flags.go 80.76% <0.00%> (-19.24%) :arrow_down:
pdata/pcommon/traceid.go 81.81% <0.00%> (-18.19%) :arrow_down:
pdata/pmetric/metrics.go 88.04% <0.00%> (-11.96%) :arrow_down:
pdata/ptrace/traces.go 80.64% <0.00%> (-11.36%) :arrow_down:
receiver/otlpreceiver/config.go 84.00% <0.00%> (-10.45%) :arrow_down:
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 09 '22 16:07 codecov[bot]

@bogdandrutu @jpkrohling @TylerHelmuth All checks are passed, please help review this again, thanks, =D

fatsheep9146 avatar Jul 25 '22 12:07 fatsheep9146

@bogdandrutu I think the failed check is not related to this pr.

fatsheep9146 avatar Jul 29 '22 01:07 fatsheep9146

PR rebased.

jpkrohling avatar Aug 01 '22 17:08 jpkrohling

PR rebased.

Done

fatsheep9146 avatar Aug 02 '22 05:08 fatsheep9146

The CI is failing due to https://github.com/open-telemetry/opentelemetry-collector/issues/5770

jpkrohling avatar Aug 02 '22 16:08 jpkrohling

The CI is failing due to #5770

Done

fatsheep9146 avatar Aug 03 '22 16:08 fatsheep9146

ping @jpkrohling, could you review this again?

fatsheep9146 avatar Aug 09 '22 09:08 fatsheep9146

unittest (1.19) didn't complete yet, PR rebased to see if this check is triggered.

jpkrohling avatar Aug 10 '22 13:08 jpkrohling

@jpkrohling unittest for 1.19 is triggered and passed =D

fatsheep9146 avatar Aug 10 '22 23:08 fatsheep9146

ping @jpkrohling for review this again, thx, =D

fatsheep9146 avatar Aug 15 '22 09:08 fatsheep9146

Sorry, I was out last week. Could you please rebase this? There seems to be a conflict that needs solving.

jpkrohling avatar Aug 22 '22 13:08 jpkrohling

Sorry, I was out last week. Could you please rebase this? There seems to be a conflict that needs solving.

I already rebased this =D @jpkrohling

fatsheep9146 avatar Aug 22 '22 14:08 fatsheep9146

Could you review this again? @jpkrohling

fatsheep9146 avatar Aug 30 '22 01:08 fatsheep9146

@bogdandrutu, you had comments on this before as well, do you want to review it again?

jpkrohling avatar Aug 30 '22 13:08 jpkrohling

ping @bogdandrutu @jpkrohling

fatsheep9146 avatar Sep 05 '22 14:09 fatsheep9146