opentelemetry-collector
opentelemetry-collector copied to clipboard
Restore "Shutdown complete" log
Fixes #5625
Testing:
I have run:
make install-tools
make
make otelcorecol
After the otelcorecol binary was built, I ran it with a simple config:
exporters:
logging:
receivers:
otlp:
protocols:
http:
service:
pipelines:
traces:
receivers:
- otlp
exporters:
- logging
and got the following log output, including the "Shutdown complete" log:
2022-07-04T12:58:21.506+0200 info service/telemetry.go:103 Setting up own telemetry...
2022-07-04T12:58:21.507+0200 info service/telemetry.go:138 Serving Prometheus metrics {"address": ":8888", "level": "basic"}
2022-07-04T12:58:21.507+0200 info extensions/extensions.go:42 Starting extensions...
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:74 Starting exporters...
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:78 Exporter is starting... {"kind": "exporter", "data_type": "traces", "name": "logging"}
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:82 Exporter started. {"kind": "exporter", "data_type": "traces", "name": "logging"}
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:86 Starting processors...
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:98 Starting receivers...
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:102 Receiver is starting... {"kind": "receiver", "name": "otlp", "pipeline": "traces"}
2022-07-04T12:58:21.507+0200 info otlpreceiver/otlp.go:88 Starting HTTP server on endpoint 0.0.0.0:4318 {"kind": "receiver", "name": "otlp", "pipeline": "traces"}
2022-07-04T12:58:21.507+0200 info pipelines/pipelines.go:106 Receiver started. {"kind": "receiver", "name": "otlp", "pipeline": "traces"}
2022-07-04T12:58:21.507+0200 info service/collector.go:215 Starting otelcorecol... {"Version": "0.54.0-dev", "NumCPU": 16}
2022-07-04T12:58:21.507+0200 info service/collector.go:128 Everything is ready. Begin running and processing data.
^C2022-07-04T12:58:24.650+0200 info service/collector.go:159 Received signal from OS {"signal": "interrupt"}
2022-07-04T12:58:24.650+0200 info service/collector.go:231 Starting shutdown...
2022-07-04T12:58:24.650+0200 info pipelines/pipelines.go:118 Stopping receivers...
2022-07-04T12:58:24.651+0200 info pipelines/pipelines.go:125 Stopping processors...
2022-07-04T12:58:24.651+0200 info pipelines/pipelines.go:132 Stopping exporters...
2022-07-04T12:58:24.651+0200 info extensions/extensions.go:56 Stopping extensions...
2022-07-04T12:58:24.651+0200 info service/collector.go:246 Shutdown complete.
Codecov Report
Merging #5626 (355bb29) into main (ac1f5be) will increase coverage by
0.03%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #5626 +/- ##
==========================================
+ Coverage 91.25% 91.28% +0.03%
==========================================
Files 191 191
Lines 11319 11320 +1
==========================================
+ Hits 10329 10334 +5
+ Misses 789 786 -3
+ Partials 201 200 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| service/collector.go | 76.38% <100.00%> (+0.16%) |
:arrow_up: |
| pdata/internal/common.go | 92.59% <0.00%> (+0.74%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ac1f5be...355bb29. Read the comment docs.
Should this PR be marked with the Skip-Changelog label?
Or is it worth adding this change to the Changelog?
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Replaced by https://github.com/open-telemetry/opentelemetry-collector/pull/5913