opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

tracer : handleTrace func() pass header to ctx

Open liguozhong opened this issue 3 years ago • 4 comments

fix tempo issue. https://github.com/grafana/tempo/issues/495 https://github.com/grafana/tempo/issues/1381

vendor/go.opentelemetry.io/collector/receiver/otlpreceiver/otlphttp.go:47 image

tempo interface image

liguozhong avatar Apr 14 '22 15:04 liguozhong

@liguozhong please mention the version you use of the collector module?

bogdandrutu avatar Apr 18 '22 15:04 bogdandrutu

@liguozhong please mention the version you use of the collector module?

@bogdandrutu ,hi ,Thank you for your patience. v0.48.0,I fork a version based on v0.48.0. After adding this header, tenantID can be received in tempo. It is expected that the header can also be passed to the downstream system in the opentelemetry-collector/main branch

https://github.com/liguozhong/opentelemetry-collector/commit/3f6214ee68930a23a656df9ea739e6b6ef457992

https://github.com/liguozhong/opentelemetry-collector/tree/v48_header

replace go.opentelemetry.io/collector => github.com/liguozhong/opentelemetry-collector v0.20.1-0.20220414164352-3f6214ee6893

image

liguozhong avatar Apr 19 '22 09:04 liguozhong

@liguozhong seems that you use a version from 2y ago:

  1. https://github.com/grafana/tempo/blob/main/go.mod#L243
  2. https://github.com/grafana/opentelemetry-collector

Based on this, I think you should first get closer to our current version, because I believe that this is actually fixed.

bogdandrutu avatar Apr 19 '22 18:04 bogdandrutu

I would also need the config file used for that. When using the batching processor, for instance, this information will be lost.

jpkrohling avatar Apr 20 '22 13:04 jpkrohling