opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Make SharedComponents public

Open tigrannajaryan opened this issue 4 years ago • 3 comments
trafficstars

It is currently internal and only used by OTLP receiver however there are other receivers that need the same functionality (any receiver that implements more than one data type needs this).

We have a duplicate in the contrib repo which is used by some contrib receivers, which is also internal. Any distro that implements a receiver like this is also forced to reimplement the SharedComponent.

I think we can simply make it public in the core and use everywhere (not sure if there is any other reason to keep it internal).

cc @bogdandrutu

tigrannajaryan avatar Oct 26 '21 13:10 tigrannajaryan

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

bogdandrutu avatar Oct 26 '21 17:10 bogdandrutu

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

Another possibility: component/componenthelper.

tigrannajaryan avatar Oct 26 '21 22:10 tigrannajaryan

There needs to be an API review, and find the right spot to have that. Maybe "pkg/sharedcomponents"?

Move from internal/sharedcomponent into component/sharedcomponent ?

RuoyuDai avatar Sep 07 '22 06:09 RuoyuDai