opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[chore][graph] Remodel node id as attribute sets

Open djaglowski opened this issue 1 year ago • 5 comments

This PR formalizes the notion that attributes are the defining identifiers for component instances in the graph package. It moves us towards the proposal described in #11343.

djaglowski avatar Oct 03 '24 20:10 djaglowski

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.60%. Comparing base (4593ba7) to head (8accdf3). Report is 101 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11344      +/-   ##
==========================================
+ Coverage   91.59%   91.60%   +0.01%     
==========================================
  Files         449      449              
  Lines       23761    23802      +41     
==========================================
+ Hits        21763    21804      +41     
  Misses       1623     1623              
  Partials      375      375              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 03 '24 20:10 codecov[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Nov 14 '24 03:11 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Dec 04 '24 03:12 github-actions[bot]

Now that #11406 is merged, this should be ready for another review. Important note - this doesn't actually change anything meaningful for users yet. It's just a way of managing the nodes in the graph internally that is closer to what the RFC states should be presented to users. Further work will be needed before users see any standardization of attributes.

djaglowski avatar Dec 05 '24 15:12 djaglowski

I've converted this back to a draft until a decision is made on https://github.com/open-telemetry/opentelemetry-collector/issues/11814. I believe the attribute sets used in this PR suffer from the same problem described in the loggers and that we should solve that problem before this change is meaningful.

djaglowski avatar Dec 16 '24 14:12 djaglowski

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Dec 31 '24 03:12 github-actions[bot]

Closing in favor of #12057

djaglowski avatar Jan 08 '25 19:01 djaglowski