[chore][graph] Remodel node id as attribute sets
This PR formalizes the notion that attributes are the defining identifiers for component instances in the graph package. It moves us towards the proposal described in #11343.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.60%. Comparing base (
4593ba7) to head (8accdf3). Report is 101 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #11344 +/- ##
==========================================
+ Coverage 91.59% 91.60% +0.01%
==========================================
Files 449 449
Lines 23761 23802 +41
==========================================
+ Hits 21763 21804 +41
Misses 1623 1623
Partials 375 375
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Now that #11406 is merged, this should be ready for another review. Important note - this doesn't actually change anything meaningful for users yet. It's just a way of managing the nodes in the graph internally that is closer to what the RFC states should be presented to users. Further work will be needed before users see any standardization of attributes.
I've converted this back to a draft until a decision is made on https://github.com/open-telemetry/opentelemetry-collector/issues/11814. I believe the attribute sets used in this PR suffer from the same problem described in the loggers and that we should solve that problem before this change is meaningful.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
Closing in favor of #12057