opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[component] Try adding PipelineID

Open TylerHelmuth opened this issue 1 year ago • 1 comments

Another investigation into https://github.com/open-telemetry/opentelemetry-collector/issues/9429 based on this strategy.

If we like this approach I can add in the Must* functions to enforce pipeline name patterns. It also doesn't really matter where PipelineID or Signal live, but componentstatus depends on PipelineID so it can't live in service.

Breaking changes in:

  • componentstatus: component.ID -> component.PipelineID
  • componentprofiles: DataTypeProfiles -> SignalProfiles
  • exporter.exporterqueue.Settings.DataType: component.DataType -> component.Signal
  • service.pipelines.Config: component.ID -> component.PipelineID
  • exporter.exportertest.CheckConsumeContractParams: component.DataType -> component.Signal
  • connector.LogsRouterAndConsumer.Consumer: component.ID -> component.PipelineID
  • connector.LogsRouterAndConsumer.PipelineIDs: component.ID -> component.PipelineID
  • connector.NewLogsRouter: component.ID -> component.PipelineID
  • connector.MetricsRouterAndConsumer.Consumer: component.ID -> component.PipelineID
  • connector.MetricsRouterAndConsumer.PipelineIDs: component.ID -> component.PipelineID
  • connector.NewMetricsRouter: component.ID -> component.PipelineID
  • connector.TracesRouterAndConsumer.Consumer: component.ID -> component.PipelineID
  • connector.TracesRouterAndConsumer.PipelineIDs: component.ID -> component.PipelineID
  • connector.NewTracesRouter: component.ID -> component.PipelineID

TylerHelmuth avatar Aug 22 '24 16:08 TylerHelmuth

Codecov Report

Attention: Patch coverage is 74.81203% with 67 lines in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (6928951) to head (0d37132). Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
component/identifiable.go 0.00% 35 Missing :warning:
component/config.go 0.00% 20 Missing :warning:
connector/internal/factory.go 58.82% 7 Missing :warning:
receiver/receivertest/nop_receiver.go 0.00% 4 Missing :warning:
service/internal/graph/nodes.go 97.91% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10947      +/-   ##
==========================================
- Coverage   92.21%   91.96%   -0.26%     
==========================================
  Files         414      414              
  Lines       19802    19857      +55     
==========================================
  Hits        18261    18261              
- Misses       1168     1223      +55     
  Partials      373      373              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 22 '24 16:08 codecov[bot]