opentelemetry-collector
opentelemetry-collector copied to clipboard
[component] Try adding PipelineID
Another investigation into https://github.com/open-telemetry/opentelemetry-collector/issues/9429 based on this strategy.
If we like this approach I can add in the Must* functions to enforce pipeline name patterns. It also doesn't really matter where PipelineID or Signal live, but componentstatus depends on PipelineID so it can't live in service.
Breaking changes in:
componentstatus:component.ID->component.PipelineIDcomponentprofiles:DataTypeProfiles->SignalProfilesexporter.exporterqueue.Settings.DataType:component.DataType->component.Signalservice.pipelines.Config:component.ID->component.PipelineIDexporter.exportertest.CheckConsumeContractParams:component.DataType->component.Signalconnector.LogsRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.LogsRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewLogsRouter:component.ID->component.PipelineIDconnector.MetricsRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.MetricsRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewMetricsRouter:component.ID->component.PipelineIDconnector.TracesRouterAndConsumer.Consumer:component.ID->component.PipelineIDconnector.TracesRouterAndConsumer.PipelineIDs:component.ID->component.PipelineIDconnector.NewTracesRouter:component.ID->component.PipelineID
Codecov Report
Attention: Patch coverage is 74.81203% with 67 lines in your changes missing coverage. Please review.
Project coverage is 91.96%. Comparing base (
6928951) to head (0d37132). Report is 89 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10947 +/- ##
==========================================
- Coverage 92.21% 91.96% -0.26%
==========================================
Files 414 414
Lines 19802 19857 +55
==========================================
Hits 18261 18261
- Misses 1168 1223 +55
Partials 373 373
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.