opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[consumer] Add tracing to all the components

Open iblancasa opened this issue 1 year ago • 3 comments

Description

Add tracing to all the components

Link to tracking issue

Fixes #8804

Testing

Based on https://github.com/open-telemetry/opentelemetry-collector/pull/8833

iblancasa avatar Aug 09 '24 15:08 iblancasa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.86%. Comparing base (30b4ed0) to head (0c5c512).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10847   +/-   ##
=======================================
  Coverage   91.85%   91.86%           
=======================================
  Files         415      416    +1     
  Lines       19850    19878   +28     
=======================================
+ Hits        18234    18260   +26     
- Misses       1244     1245    +1     
- Partials      372      373    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 09 '24 15:08 codecov[bot]

Hi @codeboten can you take a look to this PR?

iblancasa avatar Aug 19 '24 12:08 iblancasa

This has the same downsides of the original PR which is that it exposes additional interface for the consumer package. I suggested #8910 as an alternative implementation but there were some challenges with that one as well.

Pinging @dmitryax and @bogdandrutu as they reviewed the original PRs

Sorry. Didn't see that one.

I would happily retake the other approach if preferred or research any possible improvements.

iblancasa avatar Aug 26 '24 06:08 iblancasa

Closing singe more discussion is needed.

iblancasa avatar Sep 23 '24 08:09 iblancasa