opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

[chore] delete unused method on nopHost

Open atoulme opened this issue 1 year ago • 6 comments
trafficstars

Description

Delete GetExporters on nopHost as it is no longer part of the interface signature.

This is a no-op and no change in API exposed directly is present since nopHost is not exported.

atoulme avatar Jul 24 '24 06:07 atoulme

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (6029cd0) to head (2676db0). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10717      +/-   ##
==========================================
+ Coverage   91.68%   91.70%   +0.02%     
==========================================
  Files         411      411              
  Lines       19294    19292       -2     
==========================================
+ Hits        17689    17692       +3     
+ Misses       1243     1239       -4     
+ Partials      362      361       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 24 '24 06:07 codecov[bot]

Seems contrib tests need updates too

songy23 avatar Jul 24 '24 13:07 songy23

@atoulme can you confirm that contrib can be updated to not use this method?

codeboten avatar Jul 24 '24 14:07 codeboten

I can confirm, it will take a PR to contrib to fix this.

atoulme avatar Jul 24 '24 17:07 atoulme

routingprocessor needs a fix

mx-psi avatar Aug 02 '24 12:08 mx-psi

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 19 '24 03:08 github-actions[bot]

https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34899 is open to unblock.

atoulme avatar Aug 28 '24 06:08 atoulme