opentelemetry-collector
opentelemetry-collector copied to clipboard
[chore] delete unused method on nopHost
Description
Delete GetExporters on nopHost as it is no longer part of the interface signature.
This is a no-op and no change in API exposed directly is present since nopHost is not exported.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.70%. Comparing base (
6029cd0) to head (2676db0). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10717 +/- ##
==========================================
+ Coverage 91.68% 91.70% +0.02%
==========================================
Files 411 411
Lines 19294 19292 -2
==========================================
+ Hits 17689 17692 +3
+ Misses 1243 1239 -4
+ Partials 362 361 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems contrib tests need updates too
@atoulme can you confirm that contrib can be updated to not use this method?
I can confirm, it will take a PR to contrib to fix this.
routingprocessor needs a fix
This PR was marked stale due to lack of activity. It will be closed in 14 days.
https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34899 is open to unblock.