opentelemetry-collector icon indicating copy to clipboard operation
opentelemetry-collector copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Stabilize module go.opentelemetry.io/collector/filter

Open atoulme opened this issue 1 year ago • 5 comments

Before stabilizing a module, an approver or maintainer must make sure that the following criteria have been met for at least two successive minor version releases (regardless of when this issue was opened):

  • [x] No open issues or PRs in the module that would require breaking changes
  • [x] No TODOs in the module code that would require breaking changes
  • [x] No deprecated symbols in the module
  • [x] No symbols marked as experimental in the module
  • [x] The module follows the Coding guidelines

Please also make sure to publicly announce our intent to stabilize the module on:

  • [x] The #otel-collector CNCF Slack Channel
  • [x] The #opentelemetry CNCF Slack channel
  • [ ] A Collector SIG meeting (if unable to attend, just add to the agenda)

To help other people verify the above criteria, please link to the announcement and other links used to complete the above in a comment on this issue.

Once all criteria are met, close this issue by moving this module to the stable module set.

atoulme avatar Jun 06 '24 04:06 atoulme

Slack announcements: https://cloud-native.slack.com/archives/CJFCJHG4Q/p1717649266923169 and https://cloud-native.slack.com/archives/C01N6P7KR6W/p1717649260132979

atoulme avatar Jun 06 '24 04:06 atoulme

Added to agenda of next SIG meeting: https://docs.google.com/document/d/1r2JC5MB7GupCE7N32EwGEXs9V_YIsPgoFiLP4VWVMkE/edit

atoulme avatar Jun 22 '24 00:06 atoulme

This is very new package. Should be considered experimental for now. I don't think it's ready for 1.0. I would suggest holding off on this one and focus on other modules for now

dmitryax avatar Jun 26 '24 16:06 dmitryax

Would this actually be used in the Collector v1 distribution we are working on #9375? (I just want to clarify if this should be prioritized by the Collector Stability Working Group or not)

mx-psi avatar Jun 26 '24 16:06 mx-psi

Would this actually be used in the Collector v1 distribution we are working on https://github.com/open-telemetry/opentelemetry-collector/issues/9375? (I just want to clarify if this should be prioritized by the Collector Stability Working Group or not)

Looks like it's not. It's currently being used by scraping receivers only. I'd suggest we wait for broader adoption of this module before declaring it 1.0. k8sattributes and docker receiver have config parts that should adopt it first

dmitryax avatar Jun 26 '24 19:06 dmitryax