opentelemetry-collector
opentelemetry-collector copied to clipboard
test(configgrpc|confighttp): sample test showcasing issue 10093
Description
This is a sample test showcasing issue https://github.com/open-telemetry/opentelemetry-collector/issues/10093
@jpkrohling same test showcasing issue https://github.com/open-telemetry/opentelemetry-collector/issues/10093
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.48%. Comparing base (
3d0189d) to head (8bae1d0). Report is 245 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10162 +/- ##
==========================================
+ Coverage 91.65% 92.48% +0.82%
==========================================
Files 356 387 +31
Lines 16847 18264 +1417
==========================================
+ Hits 15441 16891 +1450
+ Misses 1063 1027 -36
- Partials 343 346 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Right! The intended usage is to set only the AuthData in custom authenticators and not touch metadata at all.
If someone tries to set the metadata in a custom authenticator (as I did), http would allow it to propagate but grpc wont. (With IncludeMetadata: true) Even though this is not the intended usage, the two protocols behave differently in this instance.
My Reason for doing so: The whole reason I tried to set Metadata in the Authenticator was because the batch processor was dropping the AuthData altogether.
All I want is to be able to propagate Authdata across the collector.
All I want is to be able to propagate Authdata across the collector
You can do that today already, except if you use the batching processor: that one will group data from potentially different connections into one single batch. Those connections came with potentially different auth data.
The proper solution would be to enhance the batch processor, so that it can also group data by auth data in addition to metadata.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
This PR was marked stale due to lack of activity. It will be closed in 14 days.
@grandwizard28 , do you think this should be closed?