opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

[exporter/doris] New component: Doris Exporter

Open joker-star-l opened this issue 1 year ago • 4 comments
trafficstars

Description: <Describe what has changed.>

First PR of New component: Doris Exporter.

Link to tracking Issue: <Issue number if applicable>

#33479

Testing: <Describe what testing was performed and which tests were added.>

Documentation: <Describe the documentation added.>

joker-star-l avatar Jun 27 '24 08:06 joker-star-l

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: joker-star-l / name: Mingxi (9b4ab5e80c15a9ba3895e180f789eedd940f049a, b7590ba2fa4b17fb5795fec89f54cb980c0abacc, ba3d5eee381d5f1e1345a200a63ab734ff9ed3ac, ef6375ed72a43fb9c1e9a06d1b4879973dd6500b, 5852779849dec1dba3bbda7c57a05fad20369638, 40c7422c22df37790ac5f3b4f6b7c20948d183e5, b51cdbcc63d76682dc363ca3b4be67a25c1d17d2, 39aa323c93ef8a817d601ecd1de8f1b49843e729, abcf28c8849502270819aedf9bc1f7caaec28b64, 285e0b3c4adba7176ad7c618a5026ccba6fee867, f23099b0b85a8467b52b4f912a9880db200ee5c6, 08549331687fd95f2d2abf9eb0e058afb72cdae0, e8da253edfefa3bd8d4d1127e780b4282a52bef5, c4585500941d579f3e04522e9e00c3c6defc4e12, 0827929dce5df8c11aed44721fe3f59961a3f934, ac18628151df5ee1050d4872e631cd8d2989fac8, 08049e3dd87a30b0c54d37dedab3f8f556e1ad4c, 617882c37446fc7f1137abe345226c4dd1b3b4f3, d6a8ee1bc6b44fcee724cc25e43f5b178a7e498e, 44e1f2c237f753762ec6600c520630c7defd0d56, 05a5e46387f7f6af41158f0f58c2fb46654ecaf4, 07aa154c32c717362b1b50d8dd8d5dd550105c7e, 791e71e237608300327c5692d75ceaff3d9d40ae, b623da1473af4305e86ec6bd54362daae6e230e8, 109d949b933e15b6115cdc71d78f2ff4e7bad4f4)

I think you can get this in quickly if you remove the impl code you have in there, and keep to the skeleton, and we can discuss the schema creation in a different PR.

atoulme avatar Jun 28 '24 16:06 atoulme

Please add a changelog as well. See make chlog-new in root to generate changelog.

atoulme avatar Jun 28 '24 16:06 atoulme

Please add a changelog as well. See make chlog-new in root to generate changelog.

Thanks for your suggestions above, I have changed the code.

joker-star-l avatar Jun 28 '24 20:06 joker-star-l

Please feel free to resolved outdated threads. It looks like you're close.

atoulme avatar Jul 11 '24 22:07 atoulme

Please feel free to resolved outdated threads. It looks like you're close.

Ok, thank you.

joker-star-l avatar Jul 12 '24 17:07 joker-star-l

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jul 28 '24 05:07 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Aug 12 '24 05:08 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@joker-star-l

AlchemyDing avatar Aug 12 '24 05:08 AlchemyDing

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@joker-star-l

Yes, I am still working on it. I don't seem to have the permission to reopen it. Could you help me reopen it?

joker-star-l avatar Aug 13 '24 13:08 joker-star-l

@atoulme @AlchemyDing Could you please tell me how to pass the codeowners check?

joker-star-l avatar Aug 13 '24 16:08 joker-star-l

you need to add a line in CODEOWNERS with the codeowners. So far you only listed me as codeowner in metadata.yaml, did you mean to add yourself as well?

atoulme avatar Aug 13 '24 16:08 atoulme

you need to add a line in CODEOWNERS with the codeowners. So far you only listed me as codeowner in metadata.yaml, did you mean to add yourself as well?

Can I be the codeowner? If so, I will add it. I thought I saw that only otel member can be codeowner. I'm not sure.

joker-star-l avatar Aug 13 '24 16:08 joker-star-l

you can be a codeowner - please add yourself to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/githubgen/allowlist.txt in the interim, and use this PR to show your involvement and become a member. Consider me an enthusiastic sponsor.

atoulme avatar Aug 13 '24 16:08 atoulme

you need to add a line in CODEOWNERS with the codeowners. So far you only listed me as codeowner in metadata.yaml, did you mean to add yourself as well?

I have added myself in metadata.yaml and allowlist.txt. When I run make update-codeowners to update the file CODEOWNERS, something went wrong:

cd cmd/githubgen && go install .
githubgen
2024/08/14 01:12:00 codeowners are not members:  member_1, member_2, ..., member_x
make: *** [Makefile:296: gengithub] Error 1

Did you mean that I should edit the CODEOWNER file manually to add a line like exporter/dorisexporter/ @open-telemetry/collector-contrib-approvers @atoulme @joker-star-l ?

joker-star-l avatar Aug 13 '24 17:08 joker-star-l

You need to edit manually because you don't have enough rights to query the member list from github.

atoulme avatar Aug 13 '24 18:08 atoulme

You need to edit manually because you don't have enough rights to query the member list from github.

Ok, thank you.

joker-star-l avatar Aug 13 '24 18:08 joker-star-l

You removed contrib, just make sure you run make gendistributions at the root and make generate in your component.

atoulme avatar Aug 13 '24 22:08 atoulme

@atoulme @AlchemyDing Hello, all checks have passed. Are there any other problems with the code? Can it be merged?

joker-star-l avatar Aug 19 '24 15:08 joker-star-l

@atoulme Hello, are there any problems with this pr? Sorry to bother you again.

joker-star-l avatar Aug 27 '24 13:08 joker-star-l

Thanks @joker-star-l, have you already applied to become a member of the opentelemetry organization?

Not yet. Could you tell me how to apply to become a member? I will contribute and support this component. If I understand correctly, from the CONTRIBUTING.md, I need to become a member.

joker-star-l avatar Aug 27 '24 16:08 joker-star-l

For sure, see the following for more details:

https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#member

codeboten avatar Aug 27 '24 16:08 codeboten