opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Capability to filter span links

Open fujin opened this issue 2 years ago • 4 comments
trafficstars

Component(s)

processor/filter

Is your feature request related to a problem? Please describe.

Some of my legacy code (difficult/impossible to change) emits OpenTracing span links (via opentracing-shim for opentelemetry) using the e..g asChildOf(parentSpan) API.

Unfortunately for me, these links were not implemented correctly and link to spans within the same trace. I'd like to be able to filter drop them so that I do not send them to my tracing vendor.

Describe the solution you'd like

Similar to filtering of span events, allow filtering of span links.

Describe alternatives you've considered

Patch the legacy code 🙃

Additional context

No response

fujin avatar Sep 12 '23 19:09 fujin

Pinging code owners:

  • processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Sep 12 '23 19:09 github-actions[bot]

@fujin thanks for raising this issue. We purposefully omitted a ottlspanlink context when we created the concept because we had no use case, but now we do.

The context would be very similar to ottlspanevent. @evan-bradley I am good with this new context, are you?

TylerHelmuth avatar Sep 12 '23 20:09 TylerHelmuth

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • processor/filter: @TylerHelmuth @boostchicken
  • pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Dec 11 '23 03:12 github-actions[bot]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • processor/filter: @TylerHelmuth @boostchicken
  • pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Feb 12 '24 03:02 github-actions[bot]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • processor/filter: @TylerHelmuth @boostchicken
  • pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Apr 15 '24 04:04 github-actions[bot]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • processor/filter: @TylerHelmuth @boostchicken
  • pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] avatar Jun 17 '24 03:06 github-actions[bot]