add no lint error checks for signalfx exporter package

[DiptoChakrabarty]

trafficstars

Description: <Describe what has changed.>

This adds error checks for the signalf exporter package

Link to tracking Issue: #9749

Testing: <Describe what testing was performed and which tests were added.>

Documentation: <Describe the documentation added.>

[DiptoChakrabarty]

How to resolve this error , can the tests be re run

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[DiptoChakrabarty]

can the tests be re run

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[dmitryax]

@DiptoChakrabarty please fix remaining issues

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[dmitryax]

Hey @DiptoChakrabarty , there are still linter issues. Please let us know if you can fix them.

golangci-lint run --allow-parallel-runners
Error: dpclient.go:140:9: Error return value of `io.Copy` is not checked (errcheck)
	io.Copy(ioutil.Discard, resp.Body)
	       ^
Error: exporter_test.go:676:25: Error return value of `sfxExp.Shutdown` is not checked (errcheck)
			defer sfxExp.Shutdown(context.Background())
			                     ^
Error: factory_test.go:650:20: Error return value is not checked (errcheck)
	setDefaultExcludes(cfg)
	                  ^
Error: eventclient.go:96:6: shadow: declaration of "err" shadows declaration at line 64 (govet)
		_, err := io.Copy(ioutil.Discard, resp.Body)
		   ^

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[atoulme]

Closing, the code changes are no longer necessary. Please comment or reopen if changes are still needed.