opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[exporter/loadbalancingexporter] ensure ring is properly initialized to prevent panic

Open jvilhuber opened this issue 3 years ago • 10 comments

Description: <Describe what has changed.> Ensure hashRing is not nil on start

Link to tracking Issue: <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/10110

Testing: Unit test added.

Documentation: No documentation change needed.

jvilhuber avatar May 18 '22 06:05 jvilhuber

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: jvilhuber / name: Jan Vilhuber (4ad21c1f377177e33aa4ea857e302ba06a639956, 225f903cb5eaa5e95638b076b47ba980664efaae, 5af9d02eebe11ba04b100cf8c5bd7890e422e084, 0b09837518a6f571dd3d945395c0c8e854fc938a, 602fbad7b90eb0dbcb7895d7ba444fd8813841d2)

linux-foundation-easycla[bot] avatar May 18 '22 06:05 linux-foundation-easycla[bot]

Thanks for the contribution @jvilhuber Can you sign the CLA as per community guidelines?

pmm-sumo avatar May 18 '22 10:05 pmm-sumo

Thanks for the contribution @jvilhuber Can you sign the CLA as per community guidelines?

Yea I'm working on it with the company I work for at the moment. I assume it'll take some time. Sorry about that.

jvilhuber avatar May 18 '22 11:05 jvilhuber

As discussed on Slack, the issue is related to initialisation of the component rather than nil slice, @jvilhuber is going to work on the fix and either update this branch/PR or create a separate one

pmm-sumo avatar May 18 '22 11:05 pmm-sumo

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jun 16 '22 05:06 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Jun 30 '22 05:06 github-actions[bot]

What's the state of this PR? Do you need a code review?

jpkrohling avatar Jul 05 '22 19:07 jpkrohling

What's the state of this PR? Do you need a code review?

I think mostly it's waiting on me (or rather my company) to sign the CLA (I'm still pushing; it's not controversial, just a matter of getting it done). More code-reviews can't hurt, though.

jvilhuber avatar Jul 11 '22 03:07 jvilhuber

CLA authorization is still failing.

jpkrohling avatar Jul 19 '22 17:07 jpkrohling

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Aug 04 '22 05:08 github-actions[bot]

@jvilhuber, do you have any news on getting the CLA approved?

jpkrohling avatar Aug 08 '22 15:08 jpkrohling

@jvilhuber, do you have any news on getting the CLA approved?

I keep pinging legal. Still waiting. Sorry.

jvilhuber avatar Aug 09 '22 08:08 jvilhuber