community
community copied to clipboard
REQUEST: Repository maintenance on opentelemetry-go* and opentelemetry-collector*
Affected Repository
https://github.com/open-telemetry/opentelemetry-go https://github.com/open-telemetry/opentelemetry-go-contrib https://github.com/open-telemetry/opentelemetry-go-instrumentation https://github.com/open-telemetry/opentelemetry-go-build-tools https://github.com/open-telemetry/opentelemetry-proto-go https://github.com/open-telemetry/opentelemetry-collector-contrib https://github.com/open-telemetry/opentelemetry-collector
Requested changes
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-contrib/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-instrumentation/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-contrib/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-instrumentation/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-go-build-tools/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-go-build-tools/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-proto-go/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-proto-go/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-collector/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-collector/settings.
Add CODECOV_TOKEN repository secret to https://github.com/open-telemetry/opentelemetry-collector-contrib/settings/secrets/actions with value taken from https://app.codecov.io/gh/open-telemetry/opentelemetry-collector-contrib/settings.
Purpose
There is a new release v4 of https://github.com/codecov/codecov-action Take notice (from release notes):
Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.
Slack thread: https://cloud-native.slack.com/archives/C01NJ7V1KRC/p1706772233505499
Expected Duration
Permanently
Repository Maintainers
@open-telemetry/go-maintainers
Please include:
- https://github.com/open-telemetry/opentelemetry-go-contrib
- https://github.com/open-telemetry/opentelemetry-go-instrumentation
- https://github.com/open-telemetry/opentelemetry-go-build-tools
- https://github.com/open-telemetry/opentelemetry-proto-go
@MrAlias Done
I can open a separate issue, but the same will be needed for the collector repositories 😬
- https://github.com/open-telemetry/opentelemetry-collector-contrib
- https://github.com/open-telemetry/opentelemetry-collector
@codeboten Updated
I learned that for dependabot the secrets needs to be additionally added to "Dependabot secrets".
I think it may be more pragmatic to generate an organization-wide token in https://app.codecov.io/account/gh/open-telemetry/org-upload-token and add organization-wide GitHub secrets for GitHub Actions and Dependabot.
ping @open-telemetry/technical-committee
@open-telemetry/technical-committee - WDYT about this suggestion:
I think it may be more pragmatic to generate an organization-wide token in https://app.codecov.io/account/gh/open-telemetry/org-upload-token and add organization-wide GitHub secrets for GitHub Actions and Dependabot.
I think its a good idea. Can go ahead an add the secret if folks agree.
@pellared @MrAlias @codeboten
I added an org-wide CODECOV_TOKEN secret. For now, I've enabled it to be accessible to all repos also beyond Go since I assume more SIGs will run into the same issue when upgrading their Codecov action.
Please let me know if it works as expected.
cc @jack-berg
Thank you @arminru. That looks to have unblocked us :tada:
@arminru CODECOV_TOKEN is missing as Dependabot organization-wide secret.
Because of this we cannot merge any of the following PRs created by Dependabot: https://github.com/open-telemetry/opentelemetry-go-build-tools/pulls/app%2Fdependabot
@pellared I added the same token also as a Dependabot org secret and triggered coverage builds for your open PRs again, now they're all passing.
@arminru Thanks. Closing.