liboqs icon indicating copy to clipboard operation
liboqs copied to clipboard

Add more test vectors for ML-KEM

Open dstebila opened this issue 1 year ago • 13 comments
trafficstars

https://github.com/C2SP/CCTV/tree/main/ML-KEM is a big collection of test vectors. We'd need a new test harness to be able to use these, but they would test even more characteristics.

dstebila avatar Mar 28 '24 18:03 dstebila

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:03:55

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:04:25

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:04:56

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:05:28

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:05:55

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:06:26

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:06:55

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

Dooray! Failure Notice

    Failure Notice




    
    Your message sent to

@.*** has failed to be delivered.

      Please refer to the below for details.
    




  
    
      
        * Recipient : 

@.***

        * Sent time : 

2024-03-29T03:07:22

        * Subject : 

Re: [open-quantum-safe/liboqs] Add more test vectors for ML-KEM (Issue #1740)

            * Remote host said : 

대외비/기밀 메일은 외부 계정으로 발송이 제한되어 일부 메일 발송 실패(수신자가 전달 설정한 경우 포함)

      This message was sent from a notification-only address that cannot accept incoming email.
      For more information, please contact           ***@***.***
    




    © Dooray!.

Hyeongcheol-An avatar Mar 28 '24 18:03 Hyeongcheol-An

https://github.com/C2SP/CCTV/tree/main/ML-KEM

Thanks Douglas. Is this .... "All test vectors are made available under the terms of the CC0 1.0."

Going to be an issue since there is a desire to include just MIT or Apache 2.0?

ashman-p avatar Mar 28 '24 18:03 ashman-p

https://github.com/C2SP/CCTV/tree/main/ML-KEM

Thanks Douglas. Is this .... "All test vectors are made available under the terms of the CC0 1.0."

Going to be an issue since there is a desire to include just MIT or Apache 2.0?

What about asking your LF colleagues with law degrees?

My (only common-sense inspired) suggestion to work around this would be to utilize these vectors, e.g., pull-and-run during CI, but not include them in OQS. We already do similar things in our external Cloudflare tests.

baentsch avatar Mar 29 '24 10:03 baentsch

I have asked Hart about whether CC0 is okay and he's looking into it.

dstebila avatar Mar 29 '24 15:03 dstebila

Regardless we can still make use of the test vectors by pulling in a commit during testing/CI rather than copying them into our repository.

dstebila avatar Mar 29 '24 15:03 dstebila

Very much agree that if we are not becoming the owner/authoritative source for these test vectors, then simply using them as part of CI (as is the case with many tools, github actions, compilers etc) is a better approach than including in the repo (which is where the license bar gets raised higher)

planetf1 avatar Apr 09 '24 10:04 planetf1