opa icon indicating copy to clipboard operation
opa copied to clipboard

[Documentation] No documentation for metric definitions

Open rudrakhp opened this issue 1 year ago • 6 comments

What is the underlying problem you're trying to solve?

I could not find any proper documentation that lists all metrics emitted by OPA or the envoy plugin today. Although the names are self explanatory, some might need a more thorough explanation. Few examples of such scenarios from top of my head:

  1. What does http send metric capture if there are multiple send calls in a single query execution?
  2. Is http send metric emitted if there is an inter query cache hit?

Please do let me know if there is any source I might have missed!

Describe the ideal solution

Although deep diving of the code gives a good insight on these questions, a documentation page/table dedicated to metrics and how they are captured will help the user interpret those metrics better.

Describe a "Good Enough" solution

If not a documentation page, a simple README would do.

Additional Context

N/A

rudrakhp avatar May 02 '24 10:05 rudrakhp

We have this section that explains the performance metrics. Feel free to update if you think it needs to be improved.

ashutosh-narkar avatar May 06 '24 16:05 ashutosh-narkar

@ashutosh-narkar I don't see the http.send() builtin metrics here (or any other builtin for that matter), will it be good to have them here? Also does OPA emit a metric for number of http.send() calls in each policy execution. Today we would have to look into policy code to check this.

rudrakhp avatar May 26 '24 08:05 rudrakhp

If you see any missing ones feel free to update. We keep on adding more metrics and probably the doc hasn't been updated.

ashutosh-narkar avatar May 28 '24 19:05 ashutosh-narkar

Also does OPA emit a metric for number of http.send() calls in each policy execution. Today we would have to look into policy code to check this.

@ashutosh-narkar any comments on this? If this metric doesn't exist yet, I could work on adding this.

rudrakhp avatar May 28 '24 22:05 rudrakhp

Also does OPA emit a metric for number of http.send() calls in each policy execution.

I don't think so. There is a metric around inter-query cache hits. It would be better if you could create a separate issue for that with details about the need for such a metric. Thanks.

ashutosh-narkar avatar May 28 '24 22:05 ashutosh-narkar

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

stale[bot] avatar Jun 27 '24 23:06 stale[bot]