gatekeeper
gatekeeper copied to clipboard
fix: Add Missing Flags as Helm Values
What this PR does / why we need it:
Add the following flags as helm values and pass down to controller-manager and audit deployment templates:
--log-level-key--log-level-encoder--cert-dir--api-cache-dir--otlp-endpoint--otlp-metric-interval--stackdriver-only-when-available--stackdriver-metric-interval--disable-enforcementaction-validation--client-ca-name--client-cn-name
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3784
Special notes for your reviewer:
I left some of the missing flags in #3784 out as I'm still determining whether they belong as chart values. I also want to be sure the right flags are passed to the appropriate deployments (some are applied to both, others are unique to controller-manager or audit), so feedback is welcome there.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 40.71%. Comparing base (3350319) to head (8ad4d8a).
:warning: Report is 492 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (8ad4d8a). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (8ad4d8a) unittests 2 1
Additional details and impacted files
@@ Coverage Diff @@
## master #3787 +/- ##
===========================================
- Coverage 54.49% 40.71% -13.79%
===========================================
Files 134 251 +117
Lines 12329 17720 +5391
===========================================
+ Hits 6719 7215 +496
- Misses 5116 9883 +4767
- Partials 494 622 +128
| Flag | Coverage Ξ | |
|---|---|---|
| unittests | 40.71% <ΓΈ> (-13.79%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@ianstanton, hello friend! Can you add some extra missing flag, it is cert-service-name
https://github.com/open-policy-agent/gatekeeper/blob/8d048b0655b0a0e7f31e172bc4aaf27b685e0714/main.go#L114C54-L114C71
Don't want create new pr, and wait approve for this feature
@ianstanton, hello friend! Can you add some extra missing flag, it is
cert-service-namehttps://github.com/open-policy-agent/gatekeeper/blob/8d048b0655b0a0e7f31e172bc4aaf27b685e0714/main.go#L114C54-L114C71 Don't want create new pr, and wait approve for this feature
@npoxopob Hey there! Sure, I can add that to this PR.
@ianstanton any updates on this?
@ianstanton any updates on this?
I can come back to this over the weekend
@ianstanton seems like build is failing