gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

feat: Add status metric to config

Open abhipatnala opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #2918

Special notes for your reviewer:

abhipatnala avatar Oct 21 '24 17:10 abhipatnala

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.82%. Comparing base (3350319) to head (1ce8461). Report is 162 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/config/config_controller.go 53.84% 4 Missing and 2 partials :warning:
pkg/controller/config/stats_reporter.go 88.46% 2 Missing and 1 partial :warning:

:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (1ce8461). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (1ce8461)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3656      +/-   ##
==========================================
- Coverage   54.49%   47.82%   -6.68%     
==========================================
  Files         134      222      +88     
  Lines       12329    18738    +6409     
==========================================
+ Hits         6719     8961    +2242     
- Misses       5116     8936    +3820     
- Partials      494      841     +347     
Flag Coverage Δ
unittests 47.82% <76.92%> (-6.68%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 21 '24 17:10 codecov-commenter

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 23 '24 22:12 stale[bot]

@open-policy-agent/gatekeeper-maintainers do we want this in?

JaydipGabani avatar Dec 26 '24 18:12 JaydipGabani

Per community call today, closing this so others can continue it later.

ritazh avatar Jan 08 '25 22:01 ritazh