gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

chore: Make service account configurable and add option to opt out of creation

Open stgrace opened this issue 1 year ago β€’ 1 comments
trafficstars

What this PR does / why we need it:

Adds an option to opt out of serviceAccount creation, much like the .Values.rbac.create already does. Additionally, allows for serviceAccountNames to be specified by users, in case they are created elsewhere.

Special notes for your reviewer: Tests can be done manually to verify if everything is still created as expected, by templating both charts with their default values:

helm template manifest_staging/charts/gatekeeper > /tmp/new.yaml
helm template charts/gatekeeper > /tmp/old.yaml

And performing a diff on these files.

stgrace avatar May 28 '24 09:05 stgrace

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.02%. Comparing base (3350319) to head (731331a). Report is 105 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (731331a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (731331a)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
- Coverage   54.49%   48.02%   -6.48%     
==========================================
  Files         134      219      +85     
  Lines       12329    14844    +2515     
==========================================
+ Hits         6719     7129     +410     
- Misses       5116     6906    +1790     
- Partials      494      809     +315     
Flag Coverage Ξ”
unittests 48.02% <ΓΈ> (-6.48%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 28 '24 23:05 codecov-commenter

@stgrace Unit tests are failing. Can you fix it?

JaydipGabani avatar Jul 09 '24 17:07 JaydipGabani