gatekeeper
gatekeeper copied to clipboard
feat: separate podlabels in controller-manager and audit deployment
What this PR does / why we need it:
We want to introduce new labels across our infrastructure and validate them using the K8sRequiredLabels policy. Depending on its workload each pod will receive a different workload label which is then used to enrich metrics collected from it. The Gatekeeper Helm chart doesn't allow setting separate labels for the controller manager pod and audit pod which will break our idea.
Special notes for your reviewer:
I was following the PR below to apply the changes here.
- https://github.com/open-policy-agent/gatekeeper/pull/1126
I had to remove {{- include "gatekeeper.podLabels" . | nindent 8 }} across all jobs since it's removed from the helpers.tpl file.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.23%. Comparing base (
3350319) to head (f8bb2b6). Report is 164 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (f8bb2b6). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (f8bb2b6) unittests 2 1
Additional details and impacted files
@@ Coverage Diff @@
## master #3378 +/- ##
==========================================
- Coverage 54.49% 48.23% -6.27%
==========================================
Files 134 219 +85
Lines 12329 14989 +2660
==========================================
+ Hits 6719 7230 +511
- Misses 5116 6946 +1830
- Partials 494 813 +319
| Flag | Coverage Ξ | |
|---|---|---|
| unittests | 48.23% <ΓΈ> (-6.27%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @ritazh, I rebased the branch onto main and wanted to ask you for a short review and approval. π
@bobertrublik looks like there are a few merge conflicts, could you ptal when you get a chance? thanks!
Thanks for approving, I fixed the conflicts. π