mmsegmentation icon indicating copy to clipboard operation
mmsegmentation copied to clipboard

[Feature] Add `--show-dir` option behavior on multi-gpu testing

Open mikigom opened this issue 4 years ago • 8 comments
trafficstars

This modification is for multi-gpu testing to support behavior of --show-dir option.

mikigom avatar Jun 04 '21 06:06 mikigom

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: Junjun2016
:white_check_mark: mikigom
:x: root


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 04 '21 06:06 CLAassistant

Codecov Report

Merging #583 (82f735a) into master (ee66167) will decrease coverage by 0.26%. The diff coverage is 0.00%.

:exclamation: Current head 82f735a differs from pull request most recent head e8cbe7c. Consider uploading reports for the commit e8cbe7c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   85.37%   85.10%   -0.27%     
==========================================
  Files         107      107              
  Lines        5847     5829      -18     
  Branches      960      954       -6     
==========================================
- Hits         4992     4961      -31     
- Misses        673      685      +12     
- Partials      182      183       +1     
Flag Coverage Δ
unittests 85.09% <0.00%> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/test.py 26.43% <0.00%> (-4.23%) :arrow_down:
mmseg/models/backbones/hrnet.py 82.45% <0.00%> (-0.88%) :arrow_down:
mmseg/datasets/pipelines/transforms.py 97.12% <0.00%> (-0.87%) :arrow_down:
mmseg/models/builder.py 91.30% <0.00%> (-0.70%) :arrow_down:
mmseg/models/necks/fpn.py 53.94% <0.00%> (-0.60%) :arrow_down:
mmseg/models/backbones/unet.py 94.87% <0.00%> (-0.05%) :arrow_down:
mmseg/models/backbones/vit.py 84.84% <0.00%> (ø)
mmseg/models/backbones/swin.py 86.89% <0.00%> (ø)
mmseg/models/backbones/resnet.py 99.28% <0.00%> (ø)
mmseg/models/necks/multilevel_neck.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee66167...e8cbe7c. Read the comment docs.

codecov[bot] avatar Jun 04 '21 07:06 codecov[bot]

Hi @mikigom Thanks for the nice feature. Could you please fix the lint error to pass the CI?

xvjiarui avatar Jun 04 '21 18:06 xvjiarui

Hi @mikigom Thanks for the nice feature. Could you please fix the lint error to pass the CI?

I fixed the lint error as you said :)

mikigom avatar Jun 10 '21 06:06 mikigom

Hi @mikigom Sorry for the late reply. Could you please fix the lint error again?

Junjun2016 avatar Jul 04 '21 18:07 Junjun2016

Hi @mikigom We will test and review it ASAP!

Junjun2016 avatar Jul 15 '21 10:07 Junjun2016

Hi @mikigom It is better to checkout a new branch for PR instead of the master. I have created a PR to your folked mmsegmentation repo.

Junjun2016 avatar Jul 19 '21 16:07 Junjun2016

Hi @mikigom Could you please fix the conflicts?

Junjun2016 avatar Sep 30 '21 18:09 Junjun2016

Hi @mikigom !We are grateful for your efforts in helping improve this open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) , where you can share your experiences, ideas, and build connections with like-minded peers.

To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤

OpenMMLab-Coodinator avatar Apr 13 '23 02:04 OpenMMLab-Coodinator