mmsegmentation icon indicating copy to clipboard operation
mmsegmentation copied to clipboard

Fix fsdp weight reading error

Open 1921134176 opened this issue 1 year ago • 1 comments

Fix fsdp weight reading error

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

I used FSDP to train the model and saved the model weights in shards. However, during testing, there were errors in reading the weights, and it was found that the reason was that the test. py script omitted the judgment of the runner type..

Modification

Referring to the train.by script, a judgment of the runner type has been added to the test.by script.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos? NO.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

1921134176 avatar Nov 21 '24 01:11 1921134176

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 21 '24 01:11 CLAassistant